Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chromeos/dbus/cros_disks_client.h

Issue 10024054: chromeos: Convert D-Bus client classes' callback arguments to const reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/cashew_client.cc ('k') | chromeos/dbus/cros_disks_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cros_disks_client.h
diff --git a/chromeos/dbus/cros_disks_client.h b/chromeos/dbus/cros_disks_client.h
index df7cf490ca5ec820e5bf599b6ceb059c8d37d1a0..88e6aee998188fbfe60cfdeab6c60f6420c7f582 100644
--- a/chromeos/dbus/cros_disks_client.h
+++ b/chromeos/dbus/cros_disks_client.h
@@ -180,40 +180,40 @@ class CHROMEOS_EXPORT CrosDisksClient {
// otherwise, |error_callback| is called.
virtual void Mount(const std::string& source_path,
MountType type,
- MountCallback callback,
- ErrorCallback error_callback) = 0;
+ const MountCallback& callback,
+ const ErrorCallback& error_callback) = 0;
// Calls Unmount method. |callback| is called after the method call succeeds,
// otherwise, |error_callback| is called.
virtual void Unmount(const std::string& device_path,
- UnmountCallback callback,
- ErrorCallback error_callback) = 0;
+ const UnmountCallback& callback,
+ const ErrorCallback& error_callback) = 0;
// Calls EnumerateAutoMountableDevices method. |callback| is called after the
// method call succeeds, otherwise, |error_callback| is called.
virtual void EnumerateAutoMountableDevices(
- EnumerateAutoMountableDevicesCallback callback,
- ErrorCallback error_callback) = 0;
+ const EnumerateAutoMountableDevicesCallback& callback,
+ const ErrorCallback& error_callback) = 0;
// Calls FormatDevice method. |callback| is called after the method call
// succeeds, otherwise, |error_callback| is called.
virtual void FormatDevice(const std::string& device_path,
const std::string& filesystem,
- FormatDeviceCallback callback,
- ErrorCallback error_callback) = 0;
+ const FormatDeviceCallback& callback,
+ const ErrorCallback& error_callback) = 0;
// Calls GetDeviceProperties method. |callback| is called after the method
// call succeeds, otherwise, |error_callback| is called.
virtual void GetDeviceProperties(const std::string& device_path,
- GetDevicePropertiesCallback callback,
- ErrorCallback error_callback) = 0;
+ const GetDevicePropertiesCallback& callback,
+ const ErrorCallback& error_callback) = 0;
// Registers given callback for events.
// |mount_event_handler| is called when mount event signal is received.
// |mount_completed_handler| is called when MountCompleted signal is received.
virtual void SetUpConnections(
- MountEventHandler mount_event_handler,
- MountCompletedHandler mount_completed_handler) = 0;
+ const MountEventHandler& mount_event_handler,
+ const MountCompletedHandler& mount_completed_handler) = 0;
// Factory function, creates a new instance and returns ownership.
// For normal usage, access the singleton via DBusThreadManager::Get().
« no previous file with comments | « chromeos/dbus/cashew_client.cc ('k') | chromeos/dbus/cros_disks_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698