Fix bug where constants were not correctly canonicalized.

Fix bug where constants were not correctly canonicalized.

Committed: https://code.google.com/p/dart/source/detail?r=6056

[ngeoffray, 2012-03-30 08:28:32]

LGTM

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
lib/compiler/implementation/compile_time_constants.dart:616: StringBuffer
writeCanonicalizedJsCode(StringBuffer buffer, Constant value) {
How about using this as the only entry point for writing a constant? So
everything outside this file would do:

compiler.constantHandler.writeConstant(value, buffer).

Then this method would dispatch to constant.writeCanonicalizedJsCode. 

Also, how about making writeJsCode and writeCanonicalizedJsCode on the Constant
classes private? Even if that file is not a library, it will be a strong
indication that it should not be used directly.

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
lib/compiler/implementation/ssa/codegen.dart:831:
node.constant.writeJsCode(buffer, handler);
How about this one? Being a num helps you know it's not needed, but that's
something a user of CTC does not have to think about, so please consider my
suggestion of a single entry-point for writing a constant.

[floitsch, 2012-03-30 18:11:49]

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
lib/compiler/implementation/compile_time_constants.dart:616: StringBuffer
writeCanonicalizedJsCode(StringBuffer buffer, Constant value) {
On 2012/03/30 08:28:32, ngeoffray wrote:
> How about using this as the only entry point for writing a constant? So
> everything outside this file would do:
> 
> compiler.constantHandler.writeConstant(value, buffer).
> 
> Then this method would dispatch to constant.writeCanonicalizedJsCode. 
> 
> Also, how about making writeJsCode and writeCanonicalizedJsCode on the
Constant
> classes private? Even if that file is not a library, it will be a strong
> indication that it should not be used directly.

Done.

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9967001/diff/1/lib/compiler/implementa...
lib/compiler/implementation/ssa/codegen.dart:831:
node.constant.writeJsCode(buffer, handler);
On 2012/03/30 08:28:32, ngeoffray wrote:
> How about this one? Being a num helps you know it's not needed, but that's
> something a user of CTC does not have to think about, so please consider my
> suggestion of a single entry-point for writing a constant.

Done.