Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: lib/compiler/implementation/emitter.dart

Issue 9967001: Fix bug where constants were not correctly canonicalized. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/emitter.dart
diff --git a/lib/compiler/implementation/emitter.dart b/lib/compiler/implementation/emitter.dart
index c7fb5b0ee3bd5c4090cab188afa99a368d746fd6..422e3e9a80c78b08d0d3b139ba4e0dcdd5035d74 100644
--- a/lib/compiler/implementation/emitter.dart
+++ b/lib/compiler/implementation/emitter.dart
@@ -147,8 +147,9 @@ function(child, parent) {
// down to the native method.
indexOfLastOptionalArgumentInParameters = count;
}
- argumentsBuffer[count] =
- handler.writeJsCode(new StringBuffer(), value).toString();
+ StringBuffer argumentBuffer = new StringBuffer();
+ handler.writeConstant(argumentBuffer, value);
+ argumentsBuffer[count] = argumentBuffer.toString();
}
}
}
« no previous file with comments | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698