Fix bug where constants were not correctly canonicalized.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
 
   String generateMethod(WorkItem work, HGraph graph) {
@@ skipping 810 matching lines @@
     // TODO(floitsch): the compile-time constant handler and the codegen
     // need to work together to avoid the parenthesis. See r4928 for an
     // implementation that still dealt with precedence.
     ConstantHandler handler = compiler.constantHandler;
     String name = handler.getNameForConstant(node.constant);
     if (name === null) {
       assert(!node.constant.isObject());
       if (node.constant.isNum()
           && expectedPrecedence == JSPrecedence.MEMBER_PRECEDENCE) {
         buffer.add('(');
         node.constant.writeJsCode(buffer, handler);

[ngeoffray, 2012/03/30 08:28:32]

How about this one? Being a num helps you know it's not needed, but that's
something a user of CTC does not have to think about, so please consider my
suggestion of a single entry-point for writing a constant.

[floitsch, 2012/03/30 18:11:49]

Done.

         buffer.add(')');
       } else {
-        node.constant.writeJsCode(buffer, handler);
+        node.constant.writeCanonicalizedJsCode(buffer, handler);
       }
     } else {
       buffer.add(compiler.namer.CURRENT_ISOLATE);
       buffer.add(".");
       buffer.add(name);
     }
   }
 
   visitLoopBranch(HLoopBranch node) {
     HBasicBlock branchBlock = currentBlock;
@@ skipping 716 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }