Issue 9877003: Move cygwin_dir to common.gypi.

Issue 9877003: Move cygwin_dir to common.gypi. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
ricow1, Søren Gjesse, Emily Fortuna

CC:
reviews_dartlang.org, zundel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move cygwin_dir to shared gypi file. Committed: https://code.google.com/p/dart/source/detail?r=6626

Patch Set 2 : Include all.gypi as well #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -87 lines)			Patch
M	dart/dart.gyp	View	1	3 chunks	+0 lines, -11 lines	3 comments	Download
M	dart/frog/dart-frog.gyp	View		3 chunks	+0 lines, -7 lines	0 comments	Download
M	dart/runtime/bin/bin.gypi	View		6 chunks	+0 lines, -31 lines	0 comments	Download
M	dart/runtime/vm/vm.gypi	View		6 chunks	+0 lines, -26 lines	0 comments	Download
M	dart/tools/gyp/all.gypi	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	dart/tools/gyp/common.gypi	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	dart/utils/apidoc/apidoc.gyp	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

Hi Emily and Søren, Could you do me a huge favor and see if this ...

8 years, 9 months ago (2012-03-28 14:55:41 UTC) #1

ahe

Also make this work when building from the toplevel directory.

8 years, 8 months ago (2012-04-17 11:48:37 UTC) #2

Emily Fortuna

Hooray! (fewer surprising build failures on Windows!) lgtm, with comment. https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp File dart/dart.gyp (right): https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp#newcode6 ...

8 years, 8 months ago (2012-04-17 20:04:09 UTC) #4

ahe

https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp File dart/dart.gyp (right): https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp#newcode6 dart/dart.gyp:6: 'variables': { On 2012/04/17 20:04:09, Emily Fortuna wrote: > ...

8 years, 8 months ago (2012-04-19 09:03:42 UTC) #5

ahe

8 years, 8 months ago (2012-04-19 09:54:42 UTC) #6

https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp
File dart/dart.gyp (right):

https://chromiumcodereview.appspot.com/9877003/diff/2001/dart/dart.gyp#newcode6
dart/dart.gyp:6: 'variables': {
On 2012/04/19 09:03:42, ahe wrote:
> On 2012/04/17 20:04:09, Emily Fortuna wrote:
> > Remove this entire 'variables' clause and the comment?
> 
> Thank you, good catch.

Addressed in https://chromiumcodereview.appspot.com/9985009/

Expand Messages | Collapse Messages