Move cygwin_dir to common.gypi.

dart/dart.gyp

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {

[Emily Fortuna, 2012/04/17 20:04:09]

Remove this entire 'variables' clause and the comment?

[ahe, 2012/04/19 09:03:42]

Thank you, good catch.

[ahe, 2012/04/19 09:54:42]

Addressed in https://chromiumcodereview.appspot.com/9985009/

     # These variables are used in the creation of the .vcproj file on
     # Windows.
-    'cygwin_dir': 'third_party/cygwin',
   },
   'targets': [
     {
       'target_name': 'compiler',
       'type': 'none',
       'dependencies': [
         'compiler/dart-compiler.gyp:dartc',
       ],
       'actions': []
     },
     {
       'target_name': 'runtime',
       'type': 'none',
       'dependencies': [
         'runtime/dart-runtime.gyp:dart',
         'runtime/dart-runtime.gyp:run_vm_tests',
         'runtime/dart-runtime.gyp:process_test',
       ],
     },
     {
       'target_name': 'create_sdk',
       'type': 'none',
-      'conditions': [
-        ['OS=="win"', {
-          'msvs_cygwin_dirs': ['<(cygwin_dir)'],
-        }],
-      ],
       'dependencies': [
         'runtime',
       ],
       'actions': [
         {
           'action_name': 'create_sdk_py',
           'inputs': [
             '<!@(["python", "frog/scripts/list_frog_files.py", "frog"])',
             # TODO(dgrove) - change these to dependencies and add dom
             # dependences once issues 754 and 755 are fixed
@@ skipping 12 matching lines @@
             'tools/create_sdk.py',
             '<(PRODUCT_DIR)/dart-sdk',
           ],
           'message': 'Creating SDK.',
         },
       ],
     },
     {
       'target_name': 'upload_sdk',
       'type': 'none',
-      'conditions': [
-        ['OS=="win"', {
-          'msvs_cygwin_dirs': ['<(cygwin_dir)'],
-        }],
-      ],
       'dependencies': [
         'create_sdk',
       ],
       'actions': [
         {
           'action_name': 'upload_sdk_py',
           'inputs': [
             '<(PRODUCT_DIR)/dart-sdk',
             'tools/upload_sdk.py',
           ],
@@ skipping 23 matching lines @@
     },
     {
       'target_name': 'api_docs',
       'type': 'none',
       'dependencies': [
         'utils/apidoc/apidoc.gyp:api_docs',
       ],
     }
   ],
 }