Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: dart/dart.gyp

Issue 9877003: Move cygwin_dir to common.gypi. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Include all.gypi as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/dart-frog.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/dart.gyp
diff --git a/dart/dart.gyp b/dart/dart.gyp
index 6bf020eda476f8dcf1dd01cadc22b2d499b91af5..b825a8288f328e6887527bfe4c42874a051cf3c8 100644
--- a/dart/dart.gyp
+++ b/dart/dart.gyp
@@ -6,7 +6,6 @@
'variables': {
Emily Fortuna 2012/04/17 20:04:09 Remove this entire 'variables' clause and the comm
ahe 2012/04/19 09:03:42 Thank you, good catch.
ahe 2012/04/19 09:54:42 Addressed in https://chromiumcodereview.appspot.co
# These variables are used in the creation of the .vcproj file on
# Windows.
- 'cygwin_dir': 'third_party/cygwin',
},
'targets': [
{
@@ -29,11 +28,6 @@
{
'target_name': 'create_sdk',
'type': 'none',
- 'conditions': [
- ['OS=="win"', {
- 'msvs_cygwin_dirs': ['<(cygwin_dir)'],
- }],
- ],
'dependencies': [
'runtime',
],
@@ -66,11 +60,6 @@
{
'target_name': 'upload_sdk',
'type': 'none',
- 'conditions': [
- ['OS=="win"', {
- 'msvs_cygwin_dirs': ['<(cygwin_dir)'],
- }],
- ],
'dependencies': [
'create_sdk',
],
« no previous file with comments | « no previous file | dart/frog/dart-frog.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698