Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9662010: Don't put private members in dart:html interfaces. (Closed)

Created:
8 years, 9 months ago by nweiz
Modified:
8 years, 9 months ago
Reviewers:
sra1, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't put private members in dart:html interfaces. This makes implementing the interfaces much easier when the implementing class doesn't have the members in question, and is a cleaner separation on the whole. Committed: https://code.google.com/p/dart/source/detail?r=5256

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -619 lines) Patch
M client/dom/scripts/systemhtml.py View 1 3 chunks +6 lines, -3 lines 0 comments Download
M client/dom/templates/html/impl/impl_Element.darttemplate View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +4 lines, -2 lines 0 comments Download
M client/html/dartium/html_dartium.dart View 34 chunks +15 lines, -152 lines 0 comments Download
M client/html/frog/html_frog.dart View 1 34 chunks +15 lines, -152 lines 0 comments Download
M client/html/generated/html/dartium/Element.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/generated/html/dartium/Node.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M client/html/generated/html/frog/Element.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/generated/html/frog/Node.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/AbstractWorker.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/DOMApplicationCache.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/Document.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M client/html/generated/html/interface/DocumentFragment.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/Element.dart View 4 chunks +0 lines, -46 lines 0 comments Download
M client/html/generated/html/interface/Event.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/EventSource.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/EventTarget.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/MessagePort.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/MouseEvent.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/Node.dart View 3 chunks +0 lines, -10 lines 0 comments Download
M client/html/generated/html/interface/NodeSelector.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/SVGDocument.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/SVGElementInstance.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/SVGStylable.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/html/generated/html/interface/WebSocket.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/Window.dart View 3 chunks +0 lines, -8 lines 0 comments Download
client/html/generated/html/interface/XMLHttpRequest.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M client/html/generated/html/interface/XMLHttpRequestUpload.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/html/release/html.dart View 34 chunks +15 lines, -152 lines 0 comments Download
M client/html/src/_Testing.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M client/html/src/shared_FactoryProviders.dart View 1 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
8 years, 9 months ago (2012-03-09 19:11:56 UTC) #1
Jacob
https://chromiumcodereview.appspot.com/9662010/diff/1/client/dom/scripts/systemhtml.py File client/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/9662010/diff/1/client/dom/scripts/systemhtml.py#newcode669 client/dom/scripts/systemhtml.py:669: if not html_getter_name or html_getter_name.startswith('_'): add a trivial IsPrivate ...
8 years, 9 months ago (2012-03-09 19:18:36 UTC) #2
nweiz
https://chromiumcodereview.appspot.com/9662010/diff/1/client/dom/scripts/systemhtml.py File client/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/9662010/diff/1/client/dom/scripts/systemhtml.py#newcode669 client/dom/scripts/systemhtml.py:669: if not html_getter_name or html_getter_name.startswith('_'): On 2012/03/09 19:18:39, Jacob ...
8 years, 9 months ago (2012-03-09 20:58:57 UTC) #3
Jacob
8 years, 9 months ago (2012-03-09 21:44:47 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698