 Chromium Code Reviews
 Chromium Code Reviews Issue 9662010:
  Don't put private members in dart:html interfaces.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
    
  
    Issue 9662010:
  Don't put private members in dart:html interfaces.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a | 
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. | 
| 4 | 4 | 
| 5 // TODO(jacobr): use _Lists.dart to remove some of the duplicated | 5 // TODO(jacobr): use _Lists.dart to remove some of the duplicated | 
| 6 // functionality. | 6 // functionality. | 
| 7 class _ChildrenElementList implements ElementList { | 7 class _ChildrenElementList implements ElementList { | 
| 8 // Raw Element. | 8 // Raw Element. | 
| 9 final _ElementImpl _element; | 9 final _ElementImpl _element; | 
| 10 final _HTMLCollectionImpl _childElements; | 10 final _HTMLCollectionImpl _childElements; | 
| (...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 526 () => new _ElementRectImpl(this), | 526 () => new _ElementRectImpl(this), | 
| 527 new Completer<ElementRect>()); | 527 new Completer<ElementRect>()); | 
| 528 } | 528 } | 
| 529 | 529 | 
| 530 Future<CSSStyleDeclaration> get computedStyle() { | 530 Future<CSSStyleDeclaration> get computedStyle() { | 
| 531 // TODO(jacobr): last param should be null, see b/5045788 | 531 // TODO(jacobr): last param should be null, see b/5045788 | 
| 532 return getComputedStyle(''); | 532 return getComputedStyle(''); | 
| 533 } | 533 } | 
| 534 | 534 | 
| 535 Future<CSSStyleDeclaration> getComputedStyle(String pseudoElement) { | 535 Future<CSSStyleDeclaration> getComputedStyle(String pseudoElement) { | 
| 536 return _createMeasurementFuture(() => | 536 return _createMeasurementFuture(() { | 
| 537 window._getComputedStyle(this, pseudoElement), | 537 final _WindowImpl win = window; | 
| 
Jacob
2012/03/09 19:18:39
You can use a handy top level getter called _windo
 
nweiz
2012/03/09 20:58:57
Done.
 | |
| 538 new Completer<CSSStyleDeclaration>()); | 538 return win._getComputedStyle(this, pseudoElement); | 
| 539 }, new Completer<CSSStyleDeclaration>()); | |
| 539 } | 540 } | 
| 540 $!MEMBERS | 541 $!MEMBERS | 
| 541 } | 542 } | 
| OLD | NEW |