Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: client/html/generated/html/frog/Node.dart

Issue 9662010: Don't put private members in dart:html interfaces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/html/generated/html/frog/Node.dart
diff --git a/client/html/generated/html/frog/Node.dart b/client/html/generated/html/frog/Node.dart
index e7d3afbcfe0ef13b7f2cf11a543b0e680908ee3e..77ae79435b9e40a06eaca78910dd1af1745d5194 100644
--- a/client/html/generated/html/frog/Node.dart
+++ b/client/html/generated/html/frog/Node.dart
@@ -22,14 +22,16 @@ class _NodeImpl extends _EventTargetImpl implements Node native "*Node" {
// TODO(jacobr): should we throw an exception if parent is already null?
_NodeImpl remove() {
if (this.parent != null) {
- this.parent._removeChild(this);
+ final _NodeImpl parent = this.parent;
+ parent._removeChild(this);
}
return this;
}
_NodeImpl replaceWith(Node otherNode) {
try {
- this.parent._replaceChild(otherNode, this);
+ final _NodeImpl parent = this.parent;
+ parent._replaceChild(otherNode, this);
} catch(var e) {
};
« no previous file with comments | « client/html/generated/html/frog/Element.dart ('k') | client/html/generated/html/interface/AbstractWorker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698