Enable new dart:html wrapperless frog bindings and wrapper dartium bindings.

Enable new dart:html wrapperless frog bindings and wrapper dartium bindings.
Split unittest.dart into unittest_html and unittest_dom

Bug fixes to the new dart:html bindings to compile with dartc.

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4998

[Jacob, 2012-03-05 21:12:54]

Enable new dart:html wrapperless frog bindings and wrapper dartium bindings
Split unittest:dart into unittest_html and unittest_dom as in the previous
approved CL.
Fix bugs in the bindings caught by dartc.
Remove all references to HtmlImpl

[vsm, 2012-03-05 21:37:35]

Can you add danrubel to review editor and sdk script changes?

And mmendez or scheglov to review dartc ones?

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/frog/html_frog.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/frog/html_frog.darttemplate:66: // Workaround for
classes like <site> that lack their own Element subclass.
File a bug to track this?

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/impl/impl_Node.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/impl/impl_Node.darttemplate:15: List copy = new
List.from(value);
I don't think this extra copy is buying anything.  You copy anyway below.

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
File client/tests/client/html/ElementTests.dart (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
client/tests/client/html/ElementTests.dart:279: var rawElement = element;
Does this need to be var?  I don't see a new definition anywhere?

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
File client/tests/client/html/html_tests.dart (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
client/tests/client/html/html_tests.dart:12: //
#source('DocumentFragmentTests.dart');
Do you have bugs filed for restoring these?

https://chromiumcodereview.appspot.com/9600035/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
(right):

https://chromiumcodereview.appspot.com/9600035/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:83: //
http://code.google.com/p/dart/issues/detail?id=1060
Is this issue still relevant?

https://chromiumcodereview.appspot.com/9600035/diff/1/dart.gyp
File dart.gyp (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/dart.gyp#newcode62
dart.gyp:62: 'client/html/html_dartium.dart',
If frog is still using client/html/release, this should probably point to those
files instead.

[sra1, 2012-03-05 21:44:58]

lgtm

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/frog/html_frog.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/frog/html_frog.darttemplate:66: // Workaround for
classes like <site> that lack their own Element subclass.
<cite>

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/impl/impl_Node.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/impl/impl_Node.darttemplate:16: text = '';
What does this do?  Does setting text like this remove all nodes?

[Jacob, 2012-03-05 21:55:29]

I'll reply to the remaining code review comments after i get done giving an
interview.

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/frog/html_frog.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/frog/html_frog.darttemplate:66: // Workaround for
classes like <site> that lack their own Element subclass.
On 2012/03/05 21:37:36, vsm wrote:
> File a bug to track this?

Done.

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/frog/html_frog.darttemplate:66: // Workaround for
classes like <site> that lack their own Element subclass.
On 2012/03/05 21:44:59, sra1 wrote:
> <cite>

oopth :)

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
File client/dom/templates/html/impl/impl_Node.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/impl/impl_Node.darttemplate:15: List copy = new
List.from(value);
On 2012/03/05 21:37:36, vsm wrote:
> I don't think this extra copy is buying anything.  You copy anyway below.

This code already has a TODO that it is doing things a slow way.

The problem case is when you write
node1.nodes = node2.nodes

Each time you append a child from node2.nodes that child will be immediately
removed from node2.nodes.

https://chromiumcodereview.appspot.com/9600035/diff/1/client/dom/templates/ht...
client/dom/templates/html/impl/impl_Node.darttemplate:16: text = '';
On 2012/03/05 21:44:59, sra1 wrote:
> What does this do?  Does setting text like this remove all nodes?
that's the goal.  remove all the old nodes and add all the new nodes.

[scheglov, 2012-03-05 22:07:55]

LGTM for dartc changes.

[nweiz, 2012-03-05 22:25:02]

lgtm++

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/dartium/impl_Document.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/dartium/impl_Document.darttemplate:9: final
dom.HTMLDocument _documentPtr;
This type will be incorrect for XML documents. If you need to access
HTML-specific members, maybe cast it to an HTMLDocument in the individual
methods or have an _htmlDocumentPtr getter.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/frog/html_frog.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/frog/html_frog.darttemplate:67: class _HTMLElementImpl
extends _ElementImpl native "*HTMLElement" {
Oh good, this was tripping me up last week.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/impl/impl_Element.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/impl/impl_Element.darttemplate:167: return
_nodeList[0];
Why doesn't #first work?

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/interface/interface_NodeSelector.darttemplate
(right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/interface/interface_NodeSelector.darttemplate:5: //
WARNING: Do not edit - generated code.
Remove

[Jacob, 2012-03-05 23:31:49]

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
File client/tests/client/html/ElementTests.dart (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
client/tests/client/html/ElementTests.dart:279: var rawElement = element;
On 2012/03/05 21:37:36, vsm wrote:
> Does this need to be var?  I don't see a new definition anywhere?
the variable name rawElement was obsolete. Removed and just used element.

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
File client/tests/client/html/html_tests.dart (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/client/tests/client/htm...
client/tests/client/html/html_tests.dart:12: //
#source('DocumentFragmentTests.dart');
On 2012/03/05 21:37:36, vsm wrote:
> Do you have bugs filed for restoring these?
Filed bugs and updated TODO msgs

https://chromiumcodereview.appspot.com/9600035/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
(right):

https://chromiumcodereview.appspot.com/9600035/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:83: //
http://code.google.com/p/dart/issues/detail?id=1060
On 2012/03/05 21:37:36, vsm wrote:
> Is this issue still relevant?

I assume it is given that the Bug says that dart:dom needs to be ignored as well
and we are now using basically the same generator as dart:dom.

https://chromiumcodereview.appspot.com/9600035/diff/1/dart.gyp
File dart.gyp (right):

https://chromiumcodereview.appspot.com/9600035/diff/1/dart.gyp#newcode62
dart.gyp:62: 'client/html/html_dartium.dart',
On 2012/03/05 21:37:36, vsm wrote:
> If frog is still using client/html/release, this should probably point to
those
> files instead.


frog is now using html_frog.dart
dartium and dartc are still using 
client/html/release at the moment.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/dartium/impl_Document.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/dartium/impl_Document.darttemplate:9: final
dom.HTMLDocument _documentPtr;
On 2012/03/05 22:25:02, nweiz wrote:
> This type will be incorrect for XML documents. If you need to access
> HTML-specific members, maybe cast it to an HTMLDocument in the individual
> methods or have an _htmlDocumentPtr getter.

I'm not sure it makes sense for you to have 
_XMLDocumentImpl inherit from _DocumentImpl
We should sync on what generator changes you'll need to make to make that case
work well.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/impl/impl_Element.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/impl/impl_Element.darttemplate:167: return
_nodeList[0];
On 2012/03/05 22:25:02, nweiz wrote:
> Why doesn't #first work?

because _nodeList is only guaranteed to be a List<Node> and we haven't gotten
.first in the List interface yet. Once we do this will be cleaner.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/interface/interface_NodeSelector.darttemplate
(right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/interface/interface_NodeSelector.darttemplate:5: //
WARNING: Do not edit - generated code.
On 2012/03/05 22:25:02, nweiz wrote:
> Remove
These files all have to have the warning because we want the generated code to
have the warning. I agree it would be less confusing if we had the code
generator  add that line. 
Perhaps even

// $GENERATED_CODE_WARNING

[nweiz, 2012-03-05 23:50:57]

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/dartium/impl_Document.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/dartium/impl_Document.darttemplate:9: final
dom.HTMLDocument _documentPtr;
On 2012/03/05 23:31:49, Jacob wrote:
> On 2012/03/05 22:25:02, nweiz wrote:
> > This type will be incorrect for XML documents. If you need to access
> > HTML-specific members, maybe cast it to an HTMLDocument in the individual
> > methods or have an _htmlDocumentPtr getter.
> 
> I'm not sure it makes sense for you to have 
> _XMLDocumentImpl inherit from _DocumentImpl
> We should sync on what generator changes you'll need to make to make that case
> work well.

I guess since most of the members are auto-generated anyway the
implementation-sharing is a lot less relevant.

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
File client/dom/templates/html/impl/impl_Element.darttemplate (right):

https://chromiumcodereview.appspot.com/9600035/diff/6050/client/dom/templates...
client/dom/templates/html/impl/impl_Element.darttemplate:167: return
_nodeList[0];
On 2012/03/05 23:31:49, Jacob wrote:
> On 2012/03/05 22:25:02, nweiz wrote:
> > Why doesn't #first work?
> 
> because _nodeList is only guaranteed to be a List<Node> and we haven't gotten
> .first in the List interface yet. Once we do this will be cleaner.

Ugh, I'd forgotten that List#first doesn't exist.

[devoncarew, 2012-03-06 00:14:23]

lgtm

Looks good from the POV of the editor -

[vsm, 2012-03-06 00:15:28]

lgtm