Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: client/testing/unittest/unittest_html.dart

Issue 9600035: Enable new dart:html wrapperless frog bindings and wrapper dartium bindings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Handle all code review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/testing/unittest/unittest_dom.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/unittest_html.dart
diff --git a/client/testing/unittest/unittest.dart b/client/testing/unittest/unittest_html.dart
similarity index 92%
rename from client/testing/unittest/unittest.dart
rename to client/testing/unittest/unittest_html.dart
index 4814cb0734a45fa4ab835d6380f2f42298545585..a307c4a2a54cab01b0087b51497e1a39cb9ab104 100644
--- a/client/testing/unittest/unittest.dart
+++ b/client/testing/unittest/unittest_html.dart
@@ -7,7 +7,7 @@
*/
#library("unittest");
-#import("dart:dom");
+#import("dart:html");
#source("shared.dart");
@@ -41,11 +41,11 @@ _platformStartTests() {
window.postMessage('unittest-suite-wait-for-done', '*');
// Listen for uncaught errors.
- window.addEventListener('error', _onErrorClosure, true);
+ window.on.error.add(_onErrorClosure);
}
_platformCompleteTests(int testsPassed, int testsFailed, int testsErrors) {
- window.removeEventListener('error', _onErrorClosure);
+ window.on.error.remove(_onErrorClosure);
if (_isLayoutTest && testsPassed == _tests.length) {
document.body.innerHTML = "PASS";
@@ -61,8 +61,10 @@ _platformCompleteTests(int testsPassed, int testsFailed, int testsErrors) {
}
if (testsPassed == _tests.length) {
- newBody.add("<tr><td colspan='3' class='unittest-pass'>All "
- + testsPassed + " tests passed</td></tr>");
+ newBody.add("""
+ <tr><td colspan='3' class='unittest-pass'>
+ All ${testsPassed} tests passed
+ </td></tr>""");
} else {
newBody.add("""
<tr><td colspan='3'>Total
« no previous file with comments | « client/testing/unittest/unittest_dom.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698