client/dom/templates/html/impl/impl_Node.darttemplate - Issue 9600035: Enable new dart:html wrapperless frog bindings and wrapper dartium bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/dom/templates/html/impl/impl_Node.darttemplate

Issue 9600035: Enable new dart:html wrapperless frog bindings and wrapper dartium bindings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle all code review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/dom/templates/html/impl/impl_Element.darttemplate ('k') | client/dom/templates/html/interface/interface_Document.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/dom/templates/html/impl/impl_Node.darttemplate

diff --git a/client/dom/templates/html/impl/impl_Node.darttemplate b/client/dom/templates/html/impl/impl_Node.darttemplate

index 893b877649bd1e55eb4bda52f196e6d76d9b03dc..e95a4e74bf2519f5379615d11df340f819013127 100644

--- a/client/dom/templates/html/impl/impl_Node.darttemplate

+++ b/client/dom/templates/html/impl/impl_Node.darttemplate

@@ -12,9 +12,10 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

void set nodes(Collection<Node> value) {

// Copy list first since we don't want liveness during iteration.

// TODO(jacobr): there is a better way to do this.

- List copy = new List.from(value);

- nodes.clear();

- nodes.addAll(copy);

+ text = '';

+ for (Node node in value) {

+ _appendChild(node);

+ }

}

// TODO(jacobr): should we throw an exception if parent is already null?