Issue 9539003: Safely wrap window.top in frog dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9539003: Safely wrap window.top in frog dom. (Closed)

Created:
8 years, 9 months ago by vsm

Modified:
8 years, 9 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Safely wrap window.top in frog dom. This is a one off to let me make progress. The general issue is filed at: http://code.google.com/p/dart/issues/detail?id=1913 Note: it looks like the generated files were a little out of date, so there are some extraneous changes here. Committed: https://code.google.com/p/dart/source/detail?r=4767

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments and merge #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+221 lines, -594 lines)			Patch
M	client/dom/dom_frog.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	client/dom/frog/dom_frog.dart	View	1	7 chunks	+66 lines, -56 lines	0 comments	Download
M	client/dom/generated/src/frog/DOMWindow.dart	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download
M	client/dom/generated/src/frog/HTMLIFrameElement.dart	View		1 chunk	+0 lines, -54 lines	0 comments	Download
M	client/dom/generated/src/frog/Uint8ClampedArray.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/Uint8ClampedArray.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_AudioContextWrappingImplementation.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart	View		2 chunks	+8 lines, -34 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DatabaseSyncWrappingImplementation.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DatabaseWrappingImplementation.dart	View		1 chunk	+9 lines, -64 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DirectoryEntryWrappingImplementation.dart	View		1 chunk	+9 lines, -65 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DirectoryReaderWrappingImplementation.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_EntryWrappingImplementation.dart	View		1 chunk	+15 lines, -92 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_FileEntryWrappingImplementation.dart	View		1 chunk	+6 lines, -18 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_StorageInfoWrappingImplementation.dart	View		1 chunk	+6 lines, -36 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_Uint8ClampedArrayWrappingImplementation.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_WorkerContextWrappingImplementation.dart	View		3 chunks	+10 lines, -50 lines	0 comments	Download
M	client/dom/scripts/systemfrog.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	client/dom/src/frog_DOMImplementation.dart	View	1	3 chunks	+13 lines, -30 lines	0 comments	Download
M	client/dom/templates/dom/frog/frog_dom.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	client/dom/templates/dom/frog/impl_DOMWindow.darttemplate	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/templates/dom/frog/impl_HTMLIFrameElement.darttemplate	View		1 chunk	+0 lines, -54 lines	0 comments	Download
M	client/tests/client/dom/InnerFrameTest.dart	View		2 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 9 months ago (2012-02-29 20:39:46 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/9539003/diff/1/client/dom/src/frog_DOM...
File client/dom/src/frog_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/9539003/diff/1/client/dom/src/frog_DOM...
client/dom/src/frog_DOMImplementation.dart:26: void focus() {
nit: use =>

https://chromiumcodereview.appspot.com/9539003/diff/1/client/dom/src/frog_DOM...
client/dom/src/frog_DOMImplementation.dart:52: if (w === window) {
It is a good thing that global get:window does not need to call _createSafe too.

https://chromiumcodereview.appspot.com/9539003/diff/1/client/dom/templates/do...
File client/dom/templates/dom/frog/impl_DOMWindow.darttemplate (right):

https://chromiumcodereview.appspot.com/9539003/diff/1/client/dom/templates/do...
client/dom/templates/dom/frog/impl_DOMWindow.darttemplate:11: Window get top() {
nit: =>

Expand Messages | Collapse Messages