Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: client/dom/generated/src/frog/DOMWindow.dart

Issue 9539003: Safely wrap window.top in frog dom. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments and merge Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/frog/dom_frog.dart ('k') | client/dom/generated/src/frog/HTMLIFrameElement.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/generated/src/frog/DOMWindow.dart
diff --git a/client/dom/generated/src/frog/DOMWindow.dart b/client/dom/generated/src/frog/DOMWindow.dart
index 41bbc6b3a096b22d972a0311747eb0d3dee0b232..b44a48eb6142ec40c5511b8f5941c833f320c41d 100644
--- a/client/dom/generated/src/frog/DOMWindow.dart
+++ b/client/dom/generated/src/frog/DOMWindow.dart
@@ -1,3 +1,6 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
class _DOMWindowJs extends _EventTargetJs implements DOMWindow native "@*DOMWindow" {
@@ -93,8 +96,6 @@ class _DOMWindowJs extends _EventTargetJs implements DOMWindow native "@*DOMWind
final _BarInfoJs toolbar;
- final _DOMWindowJs top;
-
final _IDBFactoryJs webkitIndexedDB;
final _NotificationCenterJs webkitNotifications;
@@ -188,4 +189,10 @@ class _DOMWindowJs extends _EventTargetJs implements DOMWindow native "@*DOMWind
void webkitRequestFileSystem(int type, int size, FileSystemCallback successCallback, [ErrorCallback errorCallback = null]) native;
void webkitResolveLocalFileSystemURL(String url, [EntryCallback successCallback = null, ErrorCallback errorCallback = null]) native;
+
+
+ Window get _top() native "return this.top;";
+
+ // Override top to return secure wrapper.
+ Window get top() => _DOMWindowCrossFrameImpl._createSafe(_top);
}
« no previous file with comments | « client/dom/frog/dom_frog.dart ('k') | client/dom/generated/src/frog/HTMLIFrameElement.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698