client/dom/scripts/systemfrog.py - Issue 9539003: Safely wrap window.top in frog dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/dom/scripts/systemfrog.py

Issue 9539003: Safely wrap window.top in frog dom. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and merge Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/dom/scripts/systemfrog.py

diff --git a/client/dom/scripts/systemfrog.py b/client/dom/scripts/systemfrog.py

index 76d86193ca3d26ed1925625f9d9029e3a872f4c1..cb8267edd04d36ffe3cad819eea591ab72c5a3ad 100644

--- a/client/dom/scripts/systemfrog.py

+++ b/client/dom/scripts/systemfrog.py

@@ -14,11 +14,12 @@ from systembase import *

# either removed or custom implemented.

_dom_frog_omitted_members = set([

# Replace with custom.

+ 'DOMWindow.get:top',

'HTMLIFrameElement.get:contentWindow',

# Remove.

- 'HTMLIFrameElement.get:contentDocument',

'DOMWindow.get:frameElement',

+ 'HTMLIFrameElement.get:contentDocument',

])

class FrogSystem(System):