Issue 9390011: Don't cache subtypes in elements. It causes a memory leak in the Editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9390011: Don't cache subtypes in elements. It causes a memory leak in the Editor. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
mmendez, scheglov, codefu, danrubel, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Don't cache subtypes in elements. It causes a memory leak in the Editor. Committed: https://code.google.com/p/dart/source/detail?r=4271

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -80 lines)			Patch
M	dart/compiler/java/com/google/dart/compiler/resolver/ClassElement.java	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	dart/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java	View	4 chunks	+0 lines, -39 lines	0 comments	Download
M	dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	6 chunks	+0 lines, -27 lines	0 comments	Download

Total messages: 4 (0 generated)

codefu

On 2012/02/13 17:30:04, ahe wrote: LGTM. It should be noted that the subtypes can be ...

8 years, 10 months ago (2012-02-14 15:06:02 UTC) #2

mmendez

lgtm Dan, the subtype question was originally meant for codegen. Since that is going away, ...

8 years, 10 months ago (2012-02-14 16:02:38 UTC) #3

lgtm