dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java - Issue 9390011: Don't cache subtypes in elements. It causes a memory leak in the Editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java

Issue 9390011: Don't cache subtypes in elements. It causes a memory leak in the Editor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java ('k') | dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java

diff --git a/dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java b/dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java

index fd2a9693bb56dd46610997d509f93b1ce1e393c4..971ff33e10df3cef13af2e667bff2dac30d963f4 100644

--- a/dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java

+++ b/dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java

@@ -20,8 +20,6 @@ import java.util.Set;

* Dummy element corresponding to {@link DynamicType}.

class DynamicElementImplementation extends AbstractElement implements DynamicElement {

- private final Set<InterfaceType> subtypes =

- Collections.<InterfaceType>singleton(Types.newDynamicType());

private DynamicElementImplementation() {

super(null, "<dynamic>");

@@ -181,11 +179,6 @@ class DynamicElementImplementation extends AbstractElement implements DynamicEle

}

@Override

- public Set<InterfaceType> getSubtypes() {

- return subtypes;

- }

- @Override

public FunctionType getFunctionType() {

return null;

}