Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java

Issue 9390011: Don't cache subtypes in elements. It causes a memory leak in the Editor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
diff --git a/dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java b/dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
index a858fb5e28ed80c9eb9dd9322612a1651c8bfa42..2fb3263c8cb7b570471b97b4ea3ececaa8ab33d6 100644
--- a/dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
+++ b/dart/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
@@ -34,16 +34,6 @@ public class ResolverTest extends ResolverTestCase {
return (ClassElement) element;
}
- private void assertHasSubtypes(ClassElement superElement, ClassElement...expectedSubtypes) {
- Set<InterfaceType> expectedInterfaceTypes = new LinkedHashSet<InterfaceType>();
- for (ClassElement expectedSubtype : expectedSubtypes) {
- expectedInterfaceTypes.add(expectedSubtype.getType());
- }
-
- Set<InterfaceType> actualSubtypes = superElement.getSubtypes();
- assertEquals(expectedInterfaceTypes, actualSubtypes);
- }
-
public void testToString() {
Assert.assertEquals("class Object {\n}", object.toString().trim());
Assert.assertEquals("class Array<E> extends Object {\n}", array.toString().trim());
@@ -100,12 +90,6 @@ public class ResolverTest extends ResolverTestCase {
ClassElement elementC = findElementOrFail(libScope, "C");
ClassElement elementD = findElementOrFail(libScope, "D");
ClassElement elementE = findElementOrFail(libScope, "E");
-
- assertHasSubtypes(elementA, elementA, elementB, elementC, elementD, elementE);
- assertHasSubtypes(elementB, elementB);
- assertHasSubtypes(elementC, elementC, elementD, elementE);
- assertHasSubtypes(elementD, elementD);
- assertHasSubtypes(elementE, elementE);
}
/**
@@ -142,12 +126,6 @@ public class ResolverTest extends ResolverTestCase {
ClassElement elementA = findElementOrFail(libScope, "A");
ClassElement elementB = findElementOrFail(libScope, "B");
- assertHasSubtypes(elementIA, elementIA, elementIB, elementIC, elementID, elementA);
- assertHasSubtypes(elementIB, elementIA, elementIB, elementIC, elementID, elementA);
- assertHasSubtypes(elementIC, elementIC);
- assertHasSubtypes(elementID, elementIA, elementIB, elementIC, elementID, elementA);
- assertHasSubtypes(elementA, elementA);
- assertHasSubtypes(elementB, elementB);
assert(elementIA.getDefaultClass().getElement().getName().equals("B"));
}
@@ -169,8 +147,6 @@ public class ResolverTest extends ResolverTestCase {
ClassElement elementIA = findElementOrFail(libScope, "IA");
ClassElement elementIB = findElementOrFail(libScope, "IB");
- assertHasSubtypes(elementIA, elementIA, elementIB);
- assertHasSubtypes(elementIB, elementIA, elementIB);
}
/**
@@ -189,8 +165,6 @@ public class ResolverTest extends ResolverTestCase {
ClassElement elementB = findElementOrFail(libScope, "B");
ClassElement elementC = findElementOrFail(libScope, "C");
- assertHasSubtypes(elementA, elementA, elementB);
- assertHasSubtypes(elementC, elementC);
}
public void testDuplicatedInterfaces() {
@@ -680,7 +654,6 @@ public class ResolverTest extends ResolverTestCase {
assertEquals(2, superTypes.size()); // Object and A
superTypes = elementIA.getAllSupertypes();
assertEquals(3, superTypes.size()); // Object, A, and B
- assertHasSubtypes(elementA, elementA, elementB, elementIA);
}
public void testUnresolvedSuper() {
« no previous file with comments | « dart/compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698