Issue 9232033: Do not set checked mode unconditionally for Dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232033: Do not set checked mode unconditionally for Dartium (Closed)

Created:
8 years, 11 months ago by vsm

Modified:
8 years, 11 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not set checked mode unconditionally for Dartium It should get picked up based on whether --checked is passed in. This should get the bot green(er). TBR=sigmund Committed: https://code.google.com/p/dart/source/detail?r=3421

Patch Set 1 #

Patch Set 2 : Add corresponding change to test.dart side. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	tools/testing/architecture.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 11 months ago (2012-01-19 00:49:46 UTC) #4

(FYI, just adding Bill just to make sure he is aware of this fix).

Expand Messages | Collapse Messages