Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: tools/testing/architecture.py

Issue 9232033: Do not set checked mode unconditionally for Dartium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add corresponding change to test.dart side. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/architecture.py
diff --git a/tools/testing/architecture.py b/tools/testing/architecture.py
index 93a18d8ffdc758eb44bb87dc7ebc378d91e28369..caf5c9acbac7d8f43ab775091bbb181b703c7bd8 100755
--- a/tools/testing/architecture.py
+++ b/tools/testing/architecture.py
@@ -290,10 +290,10 @@ class BrowserArchitecture(Architecture):
drt_location += '.app/Contents/MacOS/DumpRenderTree'
drt_flags = ['--no-timeout']
- dart_flags = '--dart-flags=--enable_asserts --enable_type_checks '
- dart_flags += ' '.join(self.vm_options)
-
- drt_flags.append(dart_flags)
+ if len(self.vm_options) > 0:
+ dart_flags = '--dart-flags='
+ dart_flags += ' '.join(self.vm_options)
+ drt_flags.append(dart_flags)
html_output_file = os.path.join(self.GetHtmlPath(), self.GetHtmlName())
f = open(html_output_file, 'w')
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698