Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Side by Side Diff: tools/testing/architecture.py

Issue 9232033: Do not set checked mode unconditionally for Dartium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add corresponding change to test.dart side. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 # 4 #
5 5
6 import os 6 import os
7 import platform 7 import platform
8 import re 8 import re
9 import shutil 9 import shutil
10 import subprocess 10 import subprocess
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 drt_location = os.path.abspath(drt_location) 283 drt_location = os.path.abspath(drt_location)
284 else: 284 else:
285 drt_location = os.path.join(self.root_path, 'client', 'tests', 'drt', 285 drt_location = os.path.join(self.root_path, 'client', 'tests', 'drt',
286 'DumpRenderTree') 286 'DumpRenderTree')
287 287
288 # On Mac DumpRenderTree is a .app folder 288 # On Mac DumpRenderTree is a .app folder
289 if platform.system() == 'Darwin': 289 if platform.system() == 'Darwin':
290 drt_location += '.app/Contents/MacOS/DumpRenderTree' 290 drt_location += '.app/Contents/MacOS/DumpRenderTree'
291 291
292 drt_flags = ['--no-timeout'] 292 drt_flags = ['--no-timeout']
293 dart_flags = '--dart-flags=--enable_asserts --enable_type_checks ' 293 if len(self.vm_options) > 0:
294 dart_flags += ' '.join(self.vm_options) 294 dart_flags = '--dart-flags='
295 295 dart_flags += ' '.join(self.vm_options)
296 drt_flags.append(dart_flags) 296 drt_flags.append(dart_flags)
297 297
298 html_output_file = os.path.join(self.GetHtmlPath(), self.GetHtmlName()) 298 html_output_file = os.path.join(self.GetHtmlPath(), self.GetHtmlName())
299 f = open(html_output_file, 'w') 299 f = open(html_output_file, 'w')
300 f.write(self.GetHtmlContents()) 300 f.write(self.GetHtmlContents())
301 f.close() 301 f.close()
302 302
303 drt_flags.append(html_output_file) 303 drt_flags.append(html_output_file)
304 304
305 return [drt_location] + drt_flags 305 return [drt_location] + drt_flags
306 306
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 return WebDriverArchitecture(root_path, arch, mode, component, test) 596 return WebDriverArchitecture(root_path, arch, mode, component, test)
597 597
598 elif component in ['vm', 'frog', 'frogsh']: 598 elif component in ['vm', 'frog', 'frogsh']:
599 return StandaloneArchitecture(root_path, arch, mode, component, test) 599 return StandaloneArchitecture(root_path, arch, mode, component, test)
600 600
601 elif component == 'leg': 601 elif component == 'leg':
602 return LegArchitecture(root_path, arch, mode, component, test) 602 return LegArchitecture(root_path, arch, mode, component, test)
603 603
604 elif component == 'dartc': 604 elif component == 'dartc':
605 return DartcArchitecture(root_path, arch, mode, component, test) 605 return DartcArchitecture(root_path, arch, mode, component, test)
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698