Issue 9231023: Categorize crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9231023: Categorize crashes. (Closed)

Created:
8 years, 11 months ago by ahe

Modified:
8 years, 11 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, floitsch, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Categorize crashes. Committed: https://code.google.com/p/dart/source/detail?r=3364

Patch Set 2 : Address review comments #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -16 lines)			Patch
M	dart/frog/leg/scanner/scanner_task.dart	View	1	1 chunk	+15 lines, -1 line	0 comments	Download
M	dart/frog/leg/tree_validator.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		8 chunks	+14 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/9231023/diff/1/dart/frog/leg/scanner/scanner_task.dart File dart/frog/leg/scanner/scanner_task.dart (right): https://chromiumcodereview.appspot.com/9231023/diff/1/dart/frog/leg/scanner/scanner_task.dart#newcode40 dart/frog/leg/scanner/scanner_task.dart:40: throw 'unrecoverable error'; Compiler.cancel should terminate the compilation, ...

8 years, 11 months ago (2012-01-17 16:54:35 UTC) #2

LGTM, thanks for doing this.

Expand Messages | Collapse Messages

Issue 9231023: Categorize crashes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages