Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: dart/frog/leg/tree_validator.dart

Issue 9231023: Categorize crashes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class TreeValidatorTask extends CompilerTask { 5 class TreeValidatorTask extends CompilerTask {
6 TreeValidatorTask(Compiler compiler) : super(compiler); 6 TreeValidatorTask(Compiler compiler) : super(compiler);
7 7
8 void validate(Node tree) { 8 void validate(Node tree) {
9 assert(check(tree)); 9 assert(check(tree));
10 } 10 }
11 11
12 bool check(Node tree) { 12 bool check(Node tree) {
13 List<InvalidNodeError> errors = []; 13 List<InvalidNodeError> errors = [];
14 void report(node, message) { 14 void report(node, message) {
15 final error = new InvalidNodeError(node, message); 15 final error = new InvalidNodeError(node, message);
16 errors.add(error); 16 errors.add(error);
17 compiler.log(error); 17 compiler.reportWarning(node, message);
18 }; 18 };
19 final validator = new ValidatorVisitor(report); 19 final validator = new ValidatorVisitor(report);
20 tree.accept(new TraversingVisitor(validator)); 20 tree.accept(new TraversingVisitor(validator));
21 21
22 return errors.isEmpty(); 22 return errors.isEmpty();
23 } 23 }
24 } 24 }
25 25
26 class ValidatorVisitor extends AbstractVisitor { 26 class ValidatorVisitor extends AbstractVisitor {
27 final Function reportInvalidNode; 27 final Function reportInvalidNode;
28 28
(...skipping 26 matching lines...) Expand all
55 final String message; 55 final String message;
56 InvalidNodeError(this.node, [this.message]); 56 InvalidNodeError(this.node, [this.message]);
57 57
58 toString() { 58 toString() {
59 String nodeString = new Unparser(true).unparse(node); 59 String nodeString = new Unparser(true).unparse(node);
60 String result = 'invalid node: $nodeString'; 60 String result = 'invalid node: $nodeString';
61 if (message !== null) result = '$result ($message)'; 61 if (message !== null) result = '$result ($message)';
62 return result; 62 return result;
63 } 63 }
64 } 64 }
OLDNEW
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698