Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: dart/frog/leg/tree_validator.dart

Issue 9231023: Categorize crashes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/tree_validator.dart
diff --git a/dart/frog/leg/tree_validator.dart b/dart/frog/leg/tree_validator.dart
index af0aa8ae39ea16627e30344a4fb2e03bc7a100b2..fab055be705cb6645b2271f819529814b66c1e51 100644
--- a/dart/frog/leg/tree_validator.dart
+++ b/dart/frog/leg/tree_validator.dart
@@ -12,10 +12,10 @@ class TreeValidatorTask extends CompilerTask {
bool check(Node tree) {
List<InvalidNodeError> errors = [];
void report(node, message) {
- final error = new InvalidNodeError(node, message);
- errors.add(error);
- compiler.log(error);
- };
+ final error = new InvalidNodeError(node, message);
+ errors.add(error);
+ compiler.reportWarning(node, message);
+ };
final validator = new ValidatorVisitor(report);
tree.accept(new TraversingVisitor(validator));
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698