Issue 9186058: Make the "sticky error" an Error instead of a String.

Issue 9186058: Make the "sticky error" an Error instead of a String. (Closed)

Created:
8 years, 11 months ago by turnidge

Modified:
8 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make the "sticky error" an Error instead of a String. I do this in preparation for using the sticky error to implement isolate unwinding. Committed: https://code.google.com/p/dart/source/detail?r=3367

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -133 lines)			Patch
M	runtime/lib/isolate.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/allocation_test.cc	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	6 chunks	+17 lines, -25 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	2 chunks	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	2 chunks	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	3 chunks	+8 lines, -11 lines	0 comments	Download
M	runtime/vm/longjump.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/longjump.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/longjump_test.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.h	View	1	2 chunks	+16 lines, -8 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	7 chunks	+50 lines, -46 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. http://codereview.chromium.org/9186058/diff/1/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): http://codereview.chromium.org/9186058/diff/1/runtime/lib/isolate.cc#newcode291 runtime/lib/isolate.cc:291: const Error& errobj = Error::Handle( err_obj?

8 years, 11 months ago (2012-01-13 01:49:06 UTC) #2

turnidge

8 years, 11 months ago (2012-01-17 19:53:46 UTC) #3

http://codereview.chromium.org/9186058/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

http://codereview.chromium.org/9186058/diff/1/runtime/lib/isolate.cc#newcode291
runtime/lib/isolate.cc:291: const Error& errobj = Error::Handle(
On 2012/01/13 01:49:06, hausner wrote:
> err_obj?

Done.

Expand Messages | Collapse Messages