Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: runtime/vm/parser.h

Issue 9186058: Make the "sticky error" an Error instead of a String. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
===================================================================
--- runtime/vm/parser.h (revision 3366)
+++ runtime/vm/parser.h (working copy)
@@ -80,15 +80,13 @@
static void ParseFunction(ParsedFunction* parsed_function);
- // Format an error or warning message into the message_buffer.
+ // Build an error object containing a formatted error or warning message.
// A null script means no source and a negative token_index means no position.
- static void FormatMessage(const Script& script,
- intptr_t token_index,
- const char* message_header,
- char* message_buffer,
- intptr_t message_buffer_size,
- const char* format,
- va_list args);
+ static RawError* FormatError(const Script& script,
+ intptr_t token_index,
+ const char* message_header,
+ const char* format,
+ va_list args);
private:
struct Block;
@@ -172,6 +170,16 @@
Function& constructor,
const AbstractTypeArguments& type_arguments);
+ // Format an error or warning message into the message_buffer.
+ // A null script means no source and a negative token_index means no position.
+ static void FormatMessage(const Script& script,
+ intptr_t token_index,
+ const char* message_header,
+ char* message_buffer,
+ intptr_t message_buffer_size,
+ const char* format,
+ va_list args);
+
// Reports error message at location of current token.
void ErrorMsg(const char* msg, ...);
void ErrorMsg(intptr_t token_index, const char* msg, ...);
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698