runtime/vm/object.cc - Issue 9186058: Make the "sticky error" an Error instead of a String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 9186058: Make the "sticky error" an Error instead of a String. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 3366)

+++ runtime/vm/object.cc (working copy)

@@ -3331,11 +3331,11 @@

}

const Type& signature_type = Type::Handle(signature_class.SignatureType());

if (!signature_type.IsFinalized()) {

- String& errmsg = String::Handle();

+ Error& error = Error::Handle();

ClassFinalizer::FinalizeAndCanonicalizeType(signature_class,

signature_type,

- &errmsg);

- ASSERT(errmsg.IsNull());

+ &error);

+ ASSERT(error.IsNull());

}

ASSERT(closure_function.signature_class() == signature_class.raw());

set_implicit_closure_function(closure_function);

« no previous file with comments | « runtime/vm/longjump_test.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »