Diagnose unterminated "grouping" characters.

Diagnose unterminated "grouping" characters.

Committed: https://code.google.com/p/dart/source/detail?r=3545

[ngeoffray, 2012-01-24 09:12:35]

LGTM!

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
File dart/frog/leg/scanner/array_based_scanner.dart (right):

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:127: groupingStack.head.endGroup
= tail;
Not related to this CL, but this is currently emitting a warning:
warning: cannot find "endGroup" on "Token"

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:140: groupingStack.head.endGroup
= tail;
ditto

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:157: groupingStack.head.endGroup
= tail;
ditto

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:32: if (ex.position is int) {
This seems fragile if we self-host. To make it robust, I would do a 'is num'
check. Or why don't you add the required fields on MalformedInputException?

[ahe, 2012-01-24 09:23:54]

Thank you, Nicolas!

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
File dart/frog/leg/scanner/array_based_scanner.dart (right):

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:127: groupingStack.head.endGroup
= tail;
On 2012/01/24 09:12:35, ngeoffray wrote:
> Not related to this CL, but this is currently emitting a warning:
> warning: cannot find "endGroup" on "Token"

Done.

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:140: groupingStack.head.endGroup
= tail;
On 2012/01/24 09:12:35, ngeoffray wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/a...
dart/frog/leg/scanner/array_based_scanner.dart:157: groupingStack.head.endGroup
= tail;
On 2012/01/24 09:12:35, ngeoffray wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9129015/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:32: if (ex.position is int) {
On 2012/01/24 09:12:35, ngeoffray wrote:
> This seems fragile if we self-host. To make it robust, I would do a 'is num'
> check. Or why don't you add the required fields on MalformedInputException?

Done. I've also added a TODO to always use tokens.

[ahe, 2012-01-24 13:10:57]

I'm going to submit now, but when you have some extra time, please look through
the changes to mini_parser.

[ngeoffray, 2012-01-24 13:27:52]

Still LGTM