Diagnose unterminated "grouping" characters.

dart/frog/leg/scanner/array_based_scanner.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ArrayBasedScanner<S> extends AbstractScanner<S> {
   int get charOffset() => byteOffset + extraCharOffset;
   final Token tokens;
   Token tail;
   int tokenStart;
   int byteOffset;
@@ skipping 40 matching lines @@
   void appendKeywordToken(Keyword keyword) {
     tail.next = new KeywordToken(keyword, tokenStart);
     tail = tail.next;
   }
 
   void appendEofToken() {
     tail.next = new Token(EOF_INFO, charOffset);
     tail = tail.next;
     // EOF points to itself so there's always infinite look-ahead.
     tail.next = tail;
+    if (!groupingStack.isEmpty()) {
+      BeginGroupToken begin = groupingStack.head;
+      throw new MalformedInputException('Unmatched ${begin.stringValue}',
+                                        begin);
+    }
   }
 
   void beginToken() {
     tokenStart = charOffset;
   }
 
   Token firstToken() {
     return tokens.next;
   }
 
@@ skipping 22 matching lines @@
     appendStringToken(info, value);
     if (groupingStack.isEmpty()) {
       return advance();
     }
     discardOpenLt();
     BeginGroupToken begin = groupingStack.head;
     if (begin.kind !== openKind) {
       if (openKind !== OPEN_CURLY_BRACKET_TOKEN ||
           begin.kind !== STRING_INTERPOLATION_TOKEN) {
         // Not ending string interpolation.
-        throw new MalformedInputException('Unmatched ${begin.stringValue}');
+        throw new MalformedInputException('Unmatched ${begin.stringValue}',
+                                          begin);
       }
       // We're ending an interpolated expression.
       begin.endGroup = tail;
       groupingStack = groupingStack.tail;
       // Using "start-of-text" to signal that we're back in string
       // scanning mode.
       return $STX;
     }
     begin.endGroup = tail;
     groupingStack = groupingStack.tail;
     return advance();
   }
 
   void appendGt(PrecedenceInfo info, String value) {
     appendStringToken(info, value);
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack.head.endGroup = tail;

[ngeoffray, 2012/01/24 09:12:35]

Not related to this CL, but this is currently emitting a warning:
warning: cannot find "endGroup" on "Token"

[ahe, 2012/01/24 09:23:54]

Done.

       groupingStack = groupingStack.tail;
     }
   }
 
   void appendGtGt(PrecedenceInfo info, String value) {
     appendStringToken(info, value);
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack = groupingStack.tail;
     }
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack.head.endGroup = tail;

[ngeoffray, 2012/01/24 09:12:35]

ditto

[ahe, 2012/01/24 09:23:54]

Done.

       groupingStack = groupingStack.tail;
     }
   }
 
   void appendGtGtGt(PrecedenceInfo info, String value) {
     appendStringToken(info, value);
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack = groupingStack.tail;
     }
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack = groupingStack.tail;
     }
     if (groupingStack.isEmpty()) return;
     if (groupingStack.head.kind === LT_TOKEN) {
       groupingStack.head.endGroup = tail;

[ngeoffray, 2012/01/24 09:12:35]

ditto

[ahe, 2012/01/24 09:23:54]

Done.

       groupingStack = groupingStack.tail;
     }
   }
 
   void discardOpenLt() {
     while (!groupingStack.isEmpty() && groupingStack.head.kind === LT_TOKEN) {
       groupingStack = groupingStack.tail;
     }
   }
 
   // TODO(ahe): make class abstract instead of adding an abstract method.
   abstract peek();
 }