Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2628)

Unified Diff: dart/frog/leg/tools/mini_parser.dart

Issue 9129015: Diagnose unterminated "grouping" characters. (Closed) Base URL: ssh://aaricia.aar/home/ahe/Dart/all/dart.googlecode.com.git@master
Patch Set: Update mini_parser Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/src/UnbalancedBraceTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/tools/mini_parser.dart
diff --git a/dart/frog/leg/tools/mini_parser.dart b/dart/frog/leg/tools/mini_parser.dart
index df5ca8f24cd62dd413e91d2767eca36f549a81d7..93addf73700e9cdfb5781c2cd2a839b1e7c09c8e 100644
--- a/dart/frog/leg/tools/mini_parser.dart
+++ b/dart/frog/leg/tools/mini_parser.dart
@@ -100,7 +100,7 @@ void parseFile(String filename, MyOptions options) {
print(ex);
}
} catch (MalformedInputException ex) {
- print('$filename: $ex');
+ // Already diagnosed.
} catch (var ex) {
print('Error in file: $filename');
throw;
@@ -121,10 +121,12 @@ Token scan(MySourceFile source) {
try {
return scanner.tokenize();
} catch (MalformedInputException ex) {
- var message = ex.message;
- if (message is !String) message = "unexpected character";
- Token fakeToken = new Token(QUESTION_INFO, scanner.charOffset);
- print(formatError(message, fakeToken, fakeToken, source));
+ if (ex.position is Token) {
+ print(formatError(ex.message, ex.position, ex.position, source));
+ } else {
+ Token fakeToken = new Token(QUESTION_INFO, ex.position);
+ print(formatError(ex.message, fakeToken, fakeToken, source));
+ }
throw;
}
}
« no previous file with comments | « dart/frog/leg/scanner/scanner_task.dart ('k') | dart/tests/language/src/UnbalancedBraceTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698