Issue 10928149: Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c…

Issue 10928149: Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c… (Closed)

Created:
8 years, 3 months ago by devoncarew

Modified:
8 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger can recurse. This CL turns off the break-on-exceptions behavior when evaluating Dart code in the debugger (in particular, the toString() method). Committed: https://code.google.com/p/dart/source/detail?r=12275

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
M	runtime/bin/dbg_connection.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

This seems to solve the problem at hand but not in general. See TODO note ...

8 years, 3 months ago (2012-09-12 17:09:59 UTC) #2

devoncarew

8 years, 3 months ago (2012-09-12 17:20:51 UTC) #3

> This seems to solve the problem at hand but not in general. See TODO note in
my comments. Otherwise lgtm with nits.

Cool. Nits addressed and TODO added. Thanks!

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/bin/dbg_con...
File runtime/bin/dbg_connection.cc (right):

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/bin/dbg_con...
runtime/bin/dbg_connection.cc:438: if (savedState != kNoPauseOnExceptions) {
On 2012/09/12 17:09:59, hausner wrote:
> Please add
> 
> TODO(hausner): Check whether recursive/reentrant pauses on exceptions should
be
> prevented in Debugger::SignalExceptionThrown() instead.

Done.

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/vm/debugger...
runtime/vm/debugger.cc:768: 
On 2012/09/12 17:09:59, hausner wrote:
> Two empty lines between functions please.

Done.

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/vm/debugger...
File runtime/vm/debugger_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10928149/diff/1007/runtime/vm/debugger...
runtime/vm/debugger_api_impl.cc:174: 
On 2012/09/12 17:09:59, hausner wrote:
> Two empty lines please.

Done.

Expand Messages | Collapse Messages