Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c…

runtime/bin/dbg_connection.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dartutils.h"
 #include "bin/socket.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 415 matching lines @@
   msg.Printf("]}}");
   SendMsg(&msg);
 }
 
 
 static void FormatTextualValue(dart::TextBuffer* buf, Dart_Handle object) {
   Dart_Handle text;
   if (Dart_IsNull(object)) {
     text = Dart_Null();
   } else {
+    Dart_ExceptionPauseInfo savedState = Dart_GetExceptionPauseInfo();
+
+    if (savedState != kNoPauseOnExceptions) {

[hausner, 2012/09/12 17:09:59]

Please add

TODO(hausner): Check whether recursive/reentrant pauses on exceptions should be
prevented in Debugger::SignalExceptionThrown() instead.

[devoncarew, 2012/09/12 17:20:52]

Done.

+      Dart_Handle res = Dart_SetExceptionPauseInfo(kNoPauseOnExceptions);
+      ASSERT_NOT_ERROR(res);
+    }
+
     text = Dart_ToString(object);
+
+    if (savedState != kNoPauseOnExceptions) {
+      Dart_Handle res = Dart_SetExceptionPauseInfo(savedState);
+      ASSERT_NOT_ERROR(res);
+    }
   }
   buf->Printf("\"text\":");
   if (Dart_IsNull(text)) {
     buf->Printf("null");
   } else if (Dart_IsError(text)) {
     FormatErrorMsg(buf, text);
   } else {
     FormatEncodedString(buf, text);
   }
 }
@@ skipping 619 matching lines @@
   DebuggerConnectionImpl::StartHandler(port_number);
   Dart_SetBreakpointHandler(BreakpointHandler);
   Dart_SetBreakpointResolvedHandler(BptResolvedHandler);
   Dart_SetExceptionThrownHandler(ExceptionThrownHandler);
 }
 
 
 DebuggerConnectionHandler::~DebuggerConnectionHandler() {
   CloseDbgConnection();
 }