Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Side by Side Diff: runtime/vm/debugger.cc

Issue 10928149: Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "vm/code_generator.h" 7 #include "vm/code_generator.h"
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 return stack_trace; 758 return stack_trace;
759 } 759 }
760 760
761 761
762 void Debugger::SetExceptionPauseInfo(Dart_ExceptionPauseInfo pause_info) { 762 void Debugger::SetExceptionPauseInfo(Dart_ExceptionPauseInfo pause_info) {
763 ASSERT((pause_info == kNoPauseOnExceptions) || 763 ASSERT((pause_info == kNoPauseOnExceptions) ||
764 (pause_info == kPauseOnUnhandledExceptions) || 764 (pause_info == kPauseOnUnhandledExceptions) ||
765 (pause_info == kPauseOnAllExceptions)); 765 (pause_info == kPauseOnAllExceptions));
766 exc_pause_info_ = pause_info; 766 exc_pause_info_ = pause_info;
767 } 767 }
768 768
hausner 2012/09/12 17:09:59 Two empty lines between functions please.
devoncarew 2012/09/12 17:20:52 Done.
769 Dart_ExceptionPauseInfo Debugger::GetExceptionPauseInfo() {
770 return (Dart_ExceptionPauseInfo)exc_pause_info_;
771 }
769 772
770 // TODO(hausner): Determine whether the exception is handled or not. 773 // TODO(hausner): Determine whether the exception is handled or not.
771 bool Debugger::ShouldPauseOnException(DebuggerStackTrace* stack_trace, 774 bool Debugger::ShouldPauseOnException(DebuggerStackTrace* stack_trace,
772 const Object& exc) { 775 const Object& exc) {
773 if (exc_pause_info_ == kNoPauseOnExceptions) { 776 if (exc_pause_info_ == kNoPauseOnExceptions) {
774 return false; 777 return false;
775 } 778 }
776 if ((exc_pause_info_ & kPauseOnAllExceptions) != 0) { 779 if ((exc_pause_info_ & kPauseOnAllExceptions) != 0) {
777 return true; 780 return true;
778 } 781 }
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
1566 } 1569 }
1567 1570
1568 1571
1569 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 1572 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
1570 ASSERT(bpt->next() == NULL); 1573 ASSERT(bpt->next() == NULL);
1571 bpt->set_next(code_breakpoints_); 1574 bpt->set_next(code_breakpoints_);
1572 code_breakpoints_ = bpt; 1575 code_breakpoints_ = bpt;
1573 } 1576 }
1574 1577
1575 } // namespace dart 1578 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698