Issue 10919182: Scrub step names to avoid breaking buildbot features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919182: Scrub step names to avoid breaking buildbot features. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Scrub step names to avoid breaking buildbot features. Committed: https://code.google.com/p/dart/source/detail?r=12096

Patch Set 2 : Address review comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	dart/utils/compiler/buildbot.py	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM, thanks https://chromiumcodereview.appspot.com/10919182/diff/1/dart/utils/compiler/buildbot.py File dart/utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10919182/diff/1/dart/utils/compiler/buildbot.py#newcode104 dart/utils/compiler/buildbot.py:104: def TestStepName(name, flags): add short comment explaining ...

8 years, 3 months ago (2012-09-09 17:55:57 UTC) #2

ahe

8 years, 3 months ago (2012-09-09 18:06:02 UTC) #3

Thank you, Rico!

https://chromiumcodereview.appspot.com/10919182/diff/1/dart/utils/compiler/bu...
File dart/utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10919182/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:104: def TestStepName(name, flags):
On 2012/09/09 17:55:57, ricow1 wrote:
> add short comment explaining that having "=" in the step name will break the
> buildbots ability to correctly extract timing stats for the step

Done.

Expand Messages | Collapse Messages

Issue 10919182: Scrub step names to avoid breaking buildbot features. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comment #

Messages