Scrub step names to avoid breaking buildbot features.

dart/utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
@@ skipping 82 matching lines @@
     print ('Error: You cannot emulate a buildbot with a platform different '
         'from your own.')
     sys.exit(1)
   return (compiler, runtime, mode, system, option, shard_index, total_shards,
           is_buildbot)
 
 
 def NeedsXterm(compiler, runtime):
   return runtime in ['ie', 'chrome', 'safari', 'opera', 'ff', 'drt']
 
+
+def TestStepName(name, flags):

[ricow1, 2012/09/09 17:55:57]

add short comment explaining that having "=" in the step name will break the
buildbots ability to correctly extract timing stats for the step

[ahe, 2012/09/09 18:06:02]

Done.

+  flags = [x for x in flags if not '=' in x]
+  return '%s tests %s' % (name, ' '.join(flags))
+
+
 def TestStep(name, mode, system, compiler, runtime, targets, flags):
-  print '@@@BUILD_STEP %s %s tests: %s %s@@@' % (name, compiler, runtime,
-      ' '.join(flags))
+  print '@@@BUILD_STEP %s@@@' % TestStepName(name, flags)
   sys.stdout.flush()
   if NeedsXterm(compiler, runtime) and system == 'linux':
     cmd = ['xvfb-run', '-a']
   else:
     cmd = []
 
   user_test = os.environ.get('USER_TEST', 'no')
 
   cmd.extend([sys.executable,
               os.path.join(os.curdir, 'tools', 'test.py'),
@@ skipping 231 matching lines @@
       and runtime != 'safari'):
     status = TestCompiler(runtime, mode, system, option,
                           test_flags + ['--checked'], is_buildbot)
 
   if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())