Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: dart/utils/compiler/buildbot.py

Issue 10919182: Scrub step names to avoid breaking buildbot features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comment Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/utils/compiler/buildbot.py
diff --git a/dart/utils/compiler/buildbot.py b/dart/utils/compiler/buildbot.py
index ba42afae6aec3589d552b20ed6727ce19e32ef90..6da39b1e23e24ecc63f3a246ece894744dfc2458 100644
--- a/dart/utils/compiler/buildbot.py
+++ b/dart/utils/compiler/buildbot.py
@@ -100,9 +100,16 @@ def GetBuildInfo():
def NeedsXterm(compiler, runtime):
return runtime in ['ie', 'chrome', 'safari', 'opera', 'ff', 'drt']
+
+def TestStepName(name, flags):
+ # Filter out flags with '=' as this breaks the /stats feature of the
+ # build bot.
+ flags = [x for x in flags if not '=' in x]
+ return '%s tests %s' % (name, ' '.join(flags))
+
+
def TestStep(name, mode, system, compiler, runtime, targets, flags):
- print '@@@BUILD_STEP %s %s tests: %s %s@@@' % (name, compiler, runtime,
- ' '.join(flags))
+ print '@@@BUILD_STEP %s@@@' % TestStepName(name, flags)
sys.stdout.flush()
if NeedsXterm(compiler, runtime) and system == 'linux':
cmd = ['xvfb-run', '-a']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698