Issue 10919119: Do not append input value of AS comparison if the check is eliminated. Fixes issue 4944, crash caus…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919119: Do not append input value of AS comparison if the check is eliminated. Fixes issue 4944, crash caus… (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
regis, Kevin Millikin (Google)

CC:
reviews_dartlang.org, regis

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not append input value of AS comparison if the check is eliminated. Fixes issue 4944, crash caused by incorrect stack size at exit. Committed: https://code.google.com/p/dart/source/detail?r=11929

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -7 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/token.h	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

I think something is not correct. See my comment. https://chromiumcodereview.appspot.com/10919119/diff/1/runtime/vm/token.h File runtime/vm/token.h (right): https://chromiumcodereview.appspot.com/10919119/diff/1/runtime/vm/token.h#newcode114 runtime/vm/token.h:114: ...

8 years, 3 months ago (2012-09-06 15:47:34 UTC) #3

srdjan

8 years, 3 months ago (2012-09-06 15:56:37 UTC) #4

https://chromiumcodereview.appspot.com/10919119/diff/1/runtime/vm/token.h
File runtime/vm/token.h (right):

https://chromiumcodereview.appspot.com/10919119/diff/1/runtime/vm/token.h#new...
runtime/vm/token.h:114: TOK(kAS, "AS", 10, kNoAttribute)                        
                    \
On 2012/09/06 15:47:34, regis wrote:
> Why is this needed? And why upper case?
> We do not want the tokenizer to recognize "AS", not even "as", since "as" is
not
> a reserved word.

Mea culpa, I added this so that the printing works. Will fix printing and
removed this.

Expand Messages | Collapse Messages