Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: runtime/vm/token.h

Issue 10919119: Do not append input value of AS comparison if the check is eliminated. Fixes issue 4944, crash caus… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/token.h
===================================================================
--- runtime/vm/token.h (revision 11916)
+++ runtime/vm/token.h (working copy)
@@ -111,7 +111,7 @@
TOK(kISNOT, "", 10, kNoAttribute) \
\
/* Internal token for (expr as Type) type cast operator */ \
- TOK(kAS, "", 10, kNoAttribute) \
+ TOK(kAS, "AS", 10, kNoAttribute) \
regis 2012/09/06 15:47:34 Why is this needed? And why upper case? We do not
srdjan 2012/09/06 15:56:37 Mea culpa, I added this so that the printing works
\
TOK(kINDEX, "[]", 0, kNoAttribute) \
TOK(kASSIGN_INDEX, "[]=", 0, kNoAttribute) \
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698