Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10919119: Do not append input value of AS comparison if the check is eliminated. Fixes issue 4944, crash caus… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/token.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 11916)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -693,10 +693,10 @@
ASSERT(type.IsFinalized()); // The type in a type cast may be malformed.
ValueGraphVisitor for_value(owner(), temp_index());
node->left()->Visit(&for_value);
- Append(for_value);
const String& dst_name = String::ZoneHandle(
Symbols::New(Exceptions::kCastExceptionDstName));
if (!CanSkipTypeCheck(node->token_pos(), for_value.value(), type, dst_name)) {
+ Append(for_value);
Do(BuildAssertAssignable(
node->token_pos(), for_value.value(), type, dst_name));
}
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/token.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698