Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10911135: Simplify the builtin functions and get rid of unused code. (Closed)

Created:
8 years, 3 months ago by siva
Modified:
8 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify functions in Builtin class and get rid of unused code. Committed: https://code.google.com/p/dart/source/detail?r=12085

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -64 lines) Patch
M bin/builtin.h View 1 chunk +1 line, -3 lines 0 comments Download
M bin/builtin.cc View 1 2 2 chunks +5 lines, -19 lines 0 comments Download
M bin/builtin_natives.cc View 2 chunks +1 line, -15 lines 0 comments Download
M bin/builtin_nolib.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M bin/dartutils.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M bin/gen_snapshot.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M bin/main.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 3 months ago (2012-09-06 23:38:58 UTC) #1
hausner
8 years, 3 months ago (2012-09-07 21:36:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698