bin/dartutils.cc - Issue 10911135: Simplify the builtin functions and get rid of unused code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bin/dartutils.cc

Issue 10911135: Simplify the builtin functions and get rid of unused code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: bin/dartutils.cc

===================================================================

--- bin/dartutils.cc (revision 11998)

+++ bin/dartutils.cc (working copy)

@@ -412,9 +412,19 @@

Dart_Handle result = Dart_SetField(print_impl,

Dart_NewString("_printClosure"), print);

- // Setup the IO library.

+ // Setup the 'timer' factory.

+ Dart_Handle url = Dart_NewString(kIsolateLibURL);

+ DART_CHECK_VALID(url);

+ Dart_Handle isolate_lib = Dart_LookupLibrary(url);

+ DART_CHECK_VALID(isolate_lib);

Dart_Handle io_lib = Builtin::LoadAndCheckLibrary(Builtin::kIOLibrary);

- Builtin::SetupIOLibrary(io_lib);

+ Dart_Handle timer_closure =

+ Dart_Invoke(io_lib, Dart_NewString("_getTimerFactoryClosure"), 0, NULL);

+ Dart_Handle args[1];

+ args[0] = timer_closure;

+ DART_CHECK_VALID(Dart_Invoke(isolate_lib,

+ Dart_NewString("_setTimerFactoryClosure"),

+ 1, args));

// Set up package root if specified.

if (package_root != NULL) {

« no previous file with comments | « bin/builtin_nolib.cc ('k') | bin/gen_snapshot.cc » ('j') | no next file with comments »