Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: bin/builtin.cc

Issue 10911135: Simplify the builtin functions and get rid of unused code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « bin/builtin.h ('k') | bin/builtin_natives.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "bin/builtin.h" 9 #include "bin/builtin.h"
10 #include "bin/dartutils.h" 10 #include "bin/dartutils.h"
(...skipping 12 matching lines...) Expand all
23 23
24 24
25 Dart_Handle Builtin::Source(BuiltinLibraryId id) { 25 Dart_Handle Builtin::Source(BuiltinLibraryId id) {
26 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 26 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
27 kInvalidLibrary); 27 kInvalidLibrary);
28 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary); 28 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
29 return Dart_NewString(builtin_libraries_[id].source_); 29 return Dart_NewString(builtin_libraries_[id].source_);
30 } 30 }
31 31
32 32
33 void Builtin::SetupLibrary(Dart_Handle library, BuiltinLibraryId id) { 33 void Builtin::SetNativeResolver(BuiltinLibraryId id) {
34 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 34 UNREACHABLE();
35 kInvalidLibrary);
36 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
37 if (builtin_libraries_[id].has_natives_) {
38 // Setup the native resolver for built in library functions.
39 DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup));
40 }
41 } 35 }
42 36
43 37
44 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) { 38 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) {
45 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 39 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
46 kInvalidLibrary); 40 kInvalidLibrary);
47 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary); 41 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
48 Dart_Handle url = Dart_NewString(builtin_libraries_[id].url_); 42 Dart_Handle url = Dart_NewString(builtin_libraries_[id].url_);
49 Dart_Handle library = Dart_LookupLibrary(url); 43 Dart_Handle library = Dart_LookupLibrary(url);
50 if (Dart_IsError(library)) { 44 if (Dart_IsError(library)) {
51 library = Dart_LoadLibrary(url, Source(id)); 45 library = Dart_LoadLibrary(url, Source(id));
52 if (!Dart_IsError(library)) { 46 if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) {
53 SetupLibrary(library, id); 47 // Setup the native resolver for built in library functions.
48 DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup));
54 } 49 }
55 } 50 }
56 DART_CHECK_VALID(library); 51 DART_CHECK_VALID(library);
57 return library; 52 return library;
58 } 53 }
59
60
61 void Builtin::ImportLibrary(Dart_Handle library, BuiltinLibraryId id) {
62 Dart_Handle imported_library = LoadAndCheckLibrary(id);
63 // Import the library into current library.
64 DART_CHECK_VALID(Dart_LibraryImportLibrary(library,
65 imported_library,
66 Dart_Null()));
67 }
OLDNEW
« no previous file with comments | « bin/builtin.h ('k') | bin/builtin_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698