Issue 10911007: Rename Type to DartType to avoid conflicts with the class Type in the core library.

Issue 10911007: Rename Type to DartType to avoid conflicts with the class Type in the core library. (Closed)

Created:
8 years, 3 months ago by karlklose

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename Type to DartType to avoid conflicts with the class Type in the core library. BUG=http://code.google.com/p/dart/issues/detail?id=4810 Committed: https://code.google.com/p/dart/source/detail?r=11619

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -271 lines)			Patch
M	lib/compiler/implementation/closure.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/compile_time_constants.dart	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	20 chunks	+27 lines, -27 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/native_emitter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/partial_type_tree.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	29 chunks	+54 lines, -53 lines	0 comments	Download
M	lib/compiler/implementation/ssa/bailout.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		6 chunks	+6 lines, -6 lines	1 comment	Download
M	lib/compiler/implementation/ssa/nodes.dart	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	lib/compiler/implementation/ssa/optimize.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/ssa.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View		20 chunks	+25 lines, -25 lines	0 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	1	34 chunks	+103 lines, -102 lines	0 comments	Download
M	lib/compiler/implementation/universe.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/world.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 3 months ago (2012-08-30 14:11:27 UTC) #2

LGTM.

http://codereview.chromium.org/10911007/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10911007/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/codegen.dart:2721: // Do nothing. DartType
guards are only used in the optimized version.
Undo this edit.

http://codereview.chromium.org/10911007/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/nodes.dart (right):

http://codereview.chromium.org/10911007/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/nodes.dart:762: // DartType codes.
Remove Dart again.

http://codereview.chromium.org/10911007/diff/2001/tests/compiler/dart2js/type...
File tests/compiler/dart2js/type_combination_test.dart (right):

http://codereview.chromium.org/10911007/diff/2001/tests/compiler/dart2js/type...
tests/compiler/dart2js/type_combination_test.dart:8: const Type(this.str);
You need to update the constructor name too. Is this used at all?

Expand Messages | Collapse Messages