Issue 10910224: Using type feedback, eliminate store barriers for indexed stores.

Issue 10910224: Using type feedback, eliminate store barriers for indexed stores. (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Using type feedback, eliminate store barriers for indexed stores. Committed: https://code.google.com/p/dart/source/detail?r=12268

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -63 lines)			Patch
M	runtime/vm/code_generator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		3 chunks	+24 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	6 chunks	+35 lines, -25 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	4 chunks	+34 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/code_generator.cc#newcode987 runtime/vm/code_generator.cc:987: const Instance& other = Instance::CheckedHandle(arguments.At(1)); why no first ...

8 years, 3 months ago (2012-09-12 15:38:09 UTC) #2

srdjan

8 years, 3 months ago (2012-09-12 15:45:25 UTC) #3

https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/code_gen...
runtime/vm/code_generator.cc:987: const Instance& other =
Instance::CheckedHandle(arguments.At(1));
On 2012/09/12 15:38:09, Vyacheslav Egorov (Google) wrote:
> why no first and second or arg1, arg2 ?

Done.

https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/stub_cod...
File runtime/vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10910224/diff/9001/runtime/vm/stub_cod...
runtime/vm/stub_code_ia32.cc:1801: Label test_two, test_three, test_four;
On 2012/09/12 15:38:09, Vyacheslav Egorov (Google) wrote:
> I think you need to remove the code above (this code replaces it).

Done.

Expand Messages | Collapse Messages