Using type feedback, eliminate store barriers for indexed stores.

runtime/vm/stub_code_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/compiler.h"
@@ skipping 1579 matching lines @@
   if (num_args == 1) {
     __ call(&get_class_id_as_smi);
     // RAX: receiver's class id as Smi.
     __ Bind(&loop);
     __ movq(R13, Address(R12, 0));  // Get class if (Smi) to check.
     __ cmpq(RAX, R13);  // Match?
     __ j(EQUAL, &found, Assembler::kNearJump);
     __ addq(R12, Immediate(kWordSize * 2));  // Next element (class + target).
     __ cmpq(R13, Immediate(Smi::RawValue(kIllegalCid)));  // Done?
     __ j(NOT_EQUAL, &loop, Assembler::kNearJump);
-  } else if (num_args == 2) {
+  } else {
     Label no_match;
     __ Bind(&loop);
-    // Get receiver.
-    __ movq(RAX, FieldAddress(R10, Array::data_offset()));
-    __ movq(RAX, Address(RSP, RAX, TIMES_4, 0));  // RAX is Smi.
-    __ call(&get_class_id_as_smi);
-    __ movq(R13, Address(R12, 0));  // Get class id from IC data to check.
-    __ cmpq(RAX, R13);  // Class id match?
-    __ j(NOT_EQUAL, &no_match, Assembler::kNearJump);
-    // Check second.
-    // Get next argument.
-    __ movq(RAX, FieldAddress(R10, Array::data_offset()));
-    __ movq(RAX, Address(RSP, RAX, TIMES_4, -kWordSize));  // RAX is Smi.
-    __ call(&get_class_id_as_smi);
-    __ movq(R13, Address(R12, kWordSize));  // Get class id from IC data.
-    __ cmpq(RAX, R13);  //  Class id match?
-    __ j(EQUAL, &found);
+    for (int i = 0; i < num_args; i++) {
+      __ movq(RAX, FieldAddress(R10, Array::data_offset()));
+      __ movq(RAX, Address(RSP, RAX, TIMES_4, - i * kWordSize));
+      __ call(&get_class_id_as_smi);
+      __ movq(R13, Address(R12, i * kWordSize));
+      __ cmpq(RAX, R13);  // Class id match?
+      if (i < (num_args - 1)) {
+        __ j(NOT_EQUAL, &no_match);
+      } else {
+        // Last check, all checks before matched.
+        __ j(EQUAL, &found);
+      }
+    }
     __ Bind(&no_match);
+    // Each test entry has (1 + num_args) array elements.
     __ addq(R12, Immediate(kWordSize * (1 + num_args)));  // Next element.
     __ cmpq(R13, Immediate(Smi::RawValue(kIllegalCid)));  // Done?
     __ j(NOT_EQUAL, &loop, Assembler::kNearJump);
   }
 
   __ Bind(&ic_miss);
   // Compute address of arguments (first read number of arguments from argument
   // descriptor array and then compute address on the stack).
   __ movq(RAX, FieldAddress(R10, Array::data_offset()));
   __ leaq(RAX, Address(RSP, RAX, TIMES_4, 0));  // RAX is Smi.
   AssemblerMacros::EnterStubFrame(assembler);
   __ pushq(R10);  // Preserve arguments array.
   __ pushq(RBX);  // Preserve IC data array
   __ pushq(raw_null);  // Setup space on stack for result (target code object).
   // Push call arguments.
   for (intptr_t i = 0; i < num_args; i++) {
     __ movq(R10, Address(RAX, -kWordSize * i));
     __ pushq(R10);
   }
   if (num_args == 1) {
     __ CallRuntime(kInlineCacheMissHandlerOneArgRuntimeEntry);
   } else if (num_args == 2) {
     __ CallRuntime(kInlineCacheMissHandlerTwoArgsRuntimeEntry);
+  } else if (num_args == 3) {
+    __ CallRuntime(kInlineCacheMissHandlerThreeArgsRuntimeEntry);
   } else {
     UNIMPLEMENTED();
   }
   // Remove call arguments pushed earlier.
   for (intptr_t i = 0; i < num_args; i++) {
     __ popq(RAX);
   }
   __ popq(RAX);  // Pop returned code object into RAX (null if not found).
   __ popq(RBX);  // Restore IC data array.
   __ popq(R10);  // Restore arguments array.
@@ skipping 44 matching lines @@
 void StubCode::GenerateOneArgCheckInlineCacheStub(Assembler* assembler) {
   return GenerateNArgsCheckInlineCacheStub(assembler, 1);
 }
 
 
 void StubCode::GenerateTwoArgsCheckInlineCacheStub(Assembler* assembler) {
   return GenerateNArgsCheckInlineCacheStub(assembler, 2);
 }
 
 
+void StubCode::GenerateThreeArgsCheckInlineCacheStub(Assembler* assembler) {
+  return GenerateNArgsCheckInlineCacheStub(assembler, 3);
+}
+
+
 //  RBX: Function object.
 //  R10: Arguments array.
 //  TOS(0): return address (Dart code).
 void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) {
   AssemblerMacros::EnterStubFrame(assembler);
   __ pushq(R10);
   __ pushq(RBX);
   __ CallRuntime(kBreakpointStaticHandlerRuntimeEntry);
   __ popq(RBX);
   __ popq(R10);
@@ skipping 28 matching lines @@
 void StubCode::GenerateBreakpointDynamicStub(Assembler* assembler) {
   AssemblerMacros::EnterStubFrame(assembler);
   __ pushq(RBX);
   __ pushq(R10);
   __ CallRuntime(kBreakpointDynamicHandlerRuntimeEntry);
   __ popq(R10);
   __ popq(RBX);
   __ LeaveFrame();
 
   // Find out which dispatch stub to call.
-  Label ic_cache_one_arg;
+  Label test_two, test_three, test_four;
   __ movq(RCX, FieldAddress(RBX, ICData::num_args_tested_offset()));
   __ cmpq(RCX, Immediate(1));
-  __ j(EQUAL, &ic_cache_one_arg, Assembler::kNearJump);
+  __ j(NOT_EQUAL, &test_two, Assembler::kNearJump);
+  __ jmp(&StubCode::OneArgCheckInlineCacheLabel());
+  __ Bind(&test_two);
+  __ cmpl(RCX, Immediate(2));
+  __ j(NOT_EQUAL, &test_three, Assembler::kNearJump);
   __ jmp(&StubCode::TwoArgsCheckInlineCacheLabel());
-  __ Bind(&ic_cache_one_arg);
-  __ jmp(&StubCode::OneArgCheckInlineCacheLabel());
+  __ Bind(&test_three);
+  __ cmpl(RCX, Immediate(3));
+  __ j(NOT_EQUAL, &test_four, Assembler::kNearJump);
+  __ jmp(&StubCode::ThreeArgsCheckInlineCacheLabel());
+  __ Bind(&test_four);
+  __ Stop("Unsupported number of arguments tested.");
 }
 
 
 // Used to check class and type arguments. Arguments passed on stack:
 // TOS + 0: return address.
 // TOS + 1: instantiator type arguments (can be NULL).
 // TOS + 2: instance.
 // TOS + 3: SubtypeTestCache.
 // Result in RCX: null -> not found, otherwise result (true or false).
 static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
@@ skipping 138 matching lines @@
 void StubCode::GenerateJumpToErrorHandlerStub(Assembler* assembler) {
   __ movq(RAX, RCX);  // error object.
   __ movq(RBP, RDX);  // target frame_pointer.
   __ movq(RSP, RSI);  // target stack_pointer.
   __ jmp(RDI);  // Jump to the exception handler code.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64