Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10910224: Using type feedback, eliminate store barriers for indexed stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 12265)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2265,7 +2265,11 @@
class StoreIndexedInstr : public TemplateDefinition<3> {
public:
- StoreIndexedInstr(Value* array, Value* index, Value* value) {
+ StoreIndexedInstr(Value* array,
+ Value* index,
+ Value* value,
+ bool emit_store_barrier)
+ : emit_store_barrier_(emit_store_barrier) {
ASSERT(array != NULL);
ASSERT(index != NULL);
ASSERT(value != NULL);
@@ -2281,10 +2285,14 @@
Value* index() const { return inputs_[1]; }
Value* value() const { return inputs_[2]; }
+ bool emit_store_barrier() const { return emit_store_barrier_; }
+
virtual bool CanDeoptimize() const { return false; }
virtual intptr_t ResultCid() const { return kDynamicCid; }
private:
+ const bool emit_store_barrier_;
+
DISALLOW_COPY_AND_ASSIGN(StoreIndexedInstr);
};
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698