Only store IC data with instructions that collect type feedback.

Only store IC data with instructions that collect type feedback.

Currently only three instructions collect IC data:
InstanceCall, EqualityOp and RelationalOp.

Specialized instructions use the IC data of the original
instance call or convert the original IC data for their
purpose.

This CL eliminates ic_data_ member from Computation and avoids
the explicit setting of ic_data in the flow graph optimizer.
Committed: https://code.google.com/p/dart/source/detail?r=11756

[srdjan, 2012-08-30 18:53:21]

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:134: deopt_id_ = isolate->GetNextDeoptId();
No need for variable isolate.

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:619: void set_ic_data(const ICData* value) {
ic_data_ = value; }
Is set_ic_data needed at all? (here and in places below).

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:654: explicit
PolymorphicInstanceCallComp(InstanceCallComp* comp,
Remove explicit

[Florian Schneider, 2012-09-03 10:33:29]

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:134: deopt_id_ = isolate->GetNextDeoptId();
On 2012/08/30 18:53:21, srdjan wrote:
> No need for variable isolate.

Done.

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:619: void set_ic_data(const ICData* value) {
ic_data_ = value; }
On 2012/08/30 18:53:21, srdjan wrote:
> Is set_ic_data needed at all? (here and in places below).

Done.

https://chromiumcodereview.appspot.com/10910003/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:654: explicit
PolymorphicInstanceCallComp(InstanceCallComp* comp,
On 2012/08/30 18:53:21, srdjan wrote:
> Remove explicit

Done.

[Vyacheslav Egorov (Google), 2012-09-03 11:14:09]

LGTM

though I find name unary_checks a bit confusing.