Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10910003: Only store IC data with instructions that collect type feedback. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 11602)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -50,13 +50,14 @@
bool CheckClassComp::AttributesEqual(Computation* other) const {
CheckClassComp* other_check = other->AsCheckClass();
if (other_check == NULL) return false;
- if (ic_data()->NumberOfChecks() != other->ic_data()->NumberOfChecks()) {
+ if (unary_checks().NumberOfChecks() !=
+ other_check->unary_checks().NumberOfChecks()) {
return false;
}
- for (intptr_t i = 0; i < ic_data()->NumberOfChecks(); ++i) {
+ for (intptr_t i = 0; i < unary_checks().NumberOfChecks(); ++i) {
// TODO(fschneider): Make sure ic_data are sorted to hit more cases.
- if (ic_data()->GetReceiverClassIdAt(i) !=
- other->ic_data()->GetReceiverClassIdAt(i)) {
+ if (unary_checks().GetReceiverClassIdAt(i) !=
+ other_check->unary_checks().GetReceiverClassIdAt(i)) {
return false;
}
}
@@ -1108,9 +1109,9 @@
Definition* CheckClassComp::TryReplace(BindInstr* instr) const {
const intptr_t v_cid = value()->ResultCid();
- const intptr_t num_checks = ic_data()->NumberOfChecks();
+ const intptr_t num_checks = unary_checks().NumberOfChecks();
if ((num_checks == 1) &&
- (v_cid == ic_data()->GetReceiverClassIdAt(0))) {
+ (v_cid == unary_checks().GetReceiverClassIdAt(0))) {
// No checks needed.
return NULL;
}
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698