Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: runtime/vm/il_printer.cc

Issue 10910003: Only store IC data with instructions that collect type feedback. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 11602)
+++ runtime/vm/il_printer.cc (working copy)
@@ -136,9 +136,6 @@
f->Print("%s:%d(", DebugName(), deopt_id_);
PrintOperandsTo(f);
f->Print(")");
- if (HasICData()) {
- PrintICData(f, *ic_data());
- }
}
@@ -199,6 +196,9 @@
f->Print(", ");
ArgumentAt(i)->value()->PrintTo(f);
}
+ if (HasICData()) {
+ PrintICData(f, *ic_data());
+ }
}
@@ -206,9 +206,7 @@
f->Print("%s(", DebugName());
instance_call()->PrintOperandsTo(f);
f->Print(") ");
- if (HasICData()) {
- PrintICData(f, *ic_data());
- }
+ PrintICData(f, ic_data());
}
@@ -224,6 +222,9 @@
left()->PrintTo(f);
f->Print(" %s ", Token::Str(kind()));
right()->PrintTo(f);
+ if (HasICData()) {
+ PrintICData(f, *ic_data());
+ }
}
@@ -297,6 +298,9 @@
left()->PrintTo(f);
f->Print(", ");
right()->PrintTo(f);
+ if (HasICData()) {
+ PrintICData(f, *ic_data());
+ }
}
@@ -415,11 +419,7 @@
void CheckClassComp::PrintOperandsTo(BufferFormatter* f) const {
value()->PrintTo(f);
- f->Print(", cid={");
- for (intptr_t i = 0; i < ic_data()->NumberOfChecks(); i++) {
- f->Print("%d ", ic_data()->GetReceiverClassIdAt(i));
- }
- f->Print("}");
+ PrintICData(f, unary_checks());
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698